Fix builder timeout #135
Labels
No labels
Compat/Breaking
Component/Enclave-Builder
Component/Infrastructure
Deploy/BYOC
Deploy/Full-managed
Deploy/Self-hosted
Interface/API
Interface/CLI
Interface/Git
Interface/Web
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority/Critical
Priority/High
Priority/Low
Priority/Medium
Reviewed/Confirmed
Reviewed/Duplicate
Reviewed/Invalid
Reviewed/Won't Fix
Status/Abandoned
Status/Blocked
Status/Need More Info
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
public/platform#135
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The build process should be checked for progress or errors rather than relying on the env var for BUILDER_TIMEOUT which could cause build jobs to be terminated even though the build is still in progress
"maybe a heartbeat updater that runs in the background every minute" - Ryan
This seems like a better way to do this, instead of a hard-coded timeout
I do think it's likely that for more testing, we'll want to adjust the timeout up, or reconsider the way that the builder fails out.
This has been resolved with @ryansquared 's work on health check code.