fix/procfile-run-command-no-split #318
No reviewers
Labels
No labels
Compat/Breaking
Component/Enclave-Builder
Component/Infrastructure
Deploy/BYOC
Deploy/Full-managed
Deploy/Self-hosted
Interface/API
Interface/CLI
Interface/Git
Interface/Web
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority/Critical
Priority/High
Priority/Low
Priority/Medium
Reviewed/Confirmed
Reviewed/Duplicate
Reviewed/Invalid
Reviewed/Won't Fix
Status/Abandoned
Status/Blocked
Status/Need More Info
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
public/platform!318
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "refs/pull/318/head"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
from_procfile shlex-split run: into command + args, but the deploy path only runs command via sh -c and ignores args. So everything after the first token got dropped — run: /app --port 8080 ran as sh -c '/app', and FOO=1 /app became sh -c 'FOO=1' (binary never started)
Fix: keep the whole run: string in command.
Follow up bug found, here: https://codeberg.org/caution/platform/issues/319
we need to keep the shlex split and quote to support automatic escaping of commands. can you readjust this to instead properly include all the necessary values?