fix/cli-hangs-unsupported-ssh-url + TOFU #341

Merged

vkobel merged 0 commits from refs/pull/341/head into main

2026-07-03 14:15:01 +00:00

vkobel commented

2026-06-29 13:59:41 +00:00

(Migrated from codeberg.org)

When a manifest's app source uses an ssh:// URL, caution verify could hang waiting for an interactive SSH prompt (host key TOFU or credentials). Three fixes:

git_url_to_archive_urls now parses ssh:// scheme URLs, so archive download is attempted before falling back to git clone
git_command sets GIT_TERMINAL_PROMPT=0, GIT_ASKPASS=true, and GIT_SSH_COMMAND with BatchMode=yes to prevent SSH from prompting via /dev/tty
StrictHostKeyChecking=accept-new — explicit TOFU: unknown hosts are accepted on first contact, changed keys are rejected (MITM protection); existing GIT_SSH_COMMAND from the caller's env is preserved and extended rather than replaced

When a manifest's app source uses an `ssh://` URL, `caution verify` could hang waiting for an interactive SSH prompt (host key TOFU or credentials). Three fixes: - `git_url_to_archive_urls` now parses `ssh://` scheme URLs, so archive download is attempted before falling back to git clone - `git_command` sets `GIT_TERMINAL_PROMPT=0`, `GIT_ASKPASS=true`, and `GIT_SSH_COMMAND` with `BatchMode=yes` to prevent SSH from prompting via `/dev/tty` - `StrictHostKeyChecking=accept-new` — explicit TOFU: unknown hosts are accepted on first contact, changed keys are rejected (MITM protection); existing `GIT_SSH_COMMAND` from the caller's env is preserved and extended rather than replaced

No reviewers

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

public/platform!341

No description provided.

Rows
Columns