public/platform
6
0
Fork 0
Code Issues 79 Pull requests 7 Projects Wiki Activity

fix/authz-role-checks #352

Closed
vkobel wants to merge 2 commits from refs/pull/352/head into main
pull from: refs/pull/352/head
merge into: public:main
Conversation 1 Commits 2 Files changed 7 +596 -34
vkobel commented 2026-07-02 09:55:59 +00:00 (Migrated from codeberg.org)
Copy link

Several write handlers only checked that the user belonged to the org, not their role — so a Viewer/Member could delete apps, manage cloud credentials, change billing, cancel the subscription, and provision resources.

This gates every state-changing endpoint on role:

  • Admin/owner required: delete resource, cloud credential create/delete/set-default, payment-method delete/set-primary, auto-topup, subscribe / change-tier / cancel subscription, builder config.
  • Viewer blocked (member allowed): deploy, create resource.

Subscription handlers now authorize before validating the tier, so non-admins get 403 rather than leaking tier validity.

Also fixes an unrelated pre-existing test-compile break (missing PLATFORM_REPO import) that blocked make test-unit.

Testing: New tests/e2e/test_authz_roles.sh (make test-e2e-authz-roles) — 14/14 steps pass, exercising viewer/member/owner against every gated endpoint.

Several write handlers only checked that the user belonged to the org, not their role — so a Viewer/Member could delete apps, manage cloud credentials, change billing, cancel the subscription, and provision resources. This gates every state-changing endpoint on role: - Admin/owner required: delete resource, cloud credential create/delete/set-default, payment-method delete/set-primary, auto-topup, subscribe / change-tier / cancel subscription, builder config. - Viewer blocked (member allowed): deploy, create resource. Subscription handlers now authorize before validating the tier, so non-admins get 403 rather than leaking tier validity. Also fixes an unrelated pre-existing test-compile break (missing PLATFORM_REPO import) that blocked make test-unit. Testing: New tests/e2e/test_authz_roles.sh (make test-e2e-authz-roles) — 14/14 steps pass, exercising viewer/member/owner against every gated endpoint.
vkobel commented 2026-07-07 07:29:37 +00:00 (Migrated from codeberg.org)
Copy link

will be part of a future refactor

will be part of a future refactor

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Compat/Breaking

Breaking change that won't be backward compatible

  
Component/Enclave-Builder

This issue affects Enclave Builder (git-push and CLI)

  
Component/Infrastructure

This issue affects generic Caution hosted infra components

  
Deploy/BYOC

Relates to Caution Bring-your-own-compute

  
Deploy/Full-managed

Relates to Caution fully managed cloud

  
Deploy/Self-hosted

Relates to Caution deployed on self-hosted infra

  
Interface/API

This issue affects the API

  
Interface/CLI

This issue affects the command line interface

  
Interface/Git

This issue affects the Git `push` interface

  
Interface/Web

This issue affects the web dashboard

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority/Critical

The priority is critical

  
Priority/High

The priority is high

  
Priority/Low

The priority is low

  
Priority/Medium

The priority is medium

  
Reviewed/Confirmed

Issue has been confirmed

  
Reviewed/Duplicate

This issue or pull request already exists

  
Reviewed/Invalid

Invalid issue

  
Reviewed/Won't Fix

This issue won't be fixed

  
Status/Abandoned

Somebody has started to work on this but abandoned work

  
Status/Blocked

Something is blocking this issue or pull request

  
Status/Need More Info

Feedback is required to reproduce issue or to continue work

No labels
Compat/Breaking
Component/Enclave-Builder
Component/Infrastructure
Deploy/BYOC
Deploy/Full-managed
Deploy/Self-hosted
Interface/API
Interface/CLI
Interface/Git
Interface/Web
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority/Critical
Priority/High
Priority/Low
Priority/Medium
Reviewed/Confirmed
Reviewed/Duplicate
Reviewed/Invalid
Reviewed/Won't Fix
Status/Abandoned
Status/Blocked
Status/Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
public/platform!352
No description provided.